Remove unused supportsYtdlProtocol from the external player map file #8107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 9, 2025
PikachuEXE
approved these changes
Oct 10, 2025
kommunarr
approved these changes
Oct 10, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 11, 2025
* development: Update next video countdown toast to be refreshed per second instead of using workaround (FreeTubeApp#8103) Remove unused supportsYtdlProtocol from the external player map file (FreeTubeApp#8107) Translated using Weblate (Dutch) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Hebrew) Hide Proxy password (FreeTubeApp#8102) # Conflicts: # src/renderer/components/FtToast/FtToast.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
ytdl://protocol links to external players #3720Description
This property has been unused since #3720, which was merged more than two years ago, so I think it's about time that we clean it up.
Testing
https://github.com/search?q=repo%3AFreeTubeApp%2FFreeTube%20supportsYtdlProtocol&type=code